Skip to content

Git – Pull Requests

Rules

  • Every PR must reference a ticket: Resolves USER-123
  • Aim for < 400 lines changed — large PRs must be split
  • Add a clear description: what changed, why, and how to test
  • Self-review your diff before requesting review
  • Address all review comments before merging
  • Require at least 1 approval (2 for critical systems)
  • All CI checks must pass before merge

PR Description Template

## What changed
Brief description of the changes made.

## Why
The reason or ticket this addresses.

## How to test
Steps to verify the changes work correctly.

## Screenshots (if UI change)
Before / After screenshots.

Review Etiquette

  • Reviewers: Be constructive — explain why and suggest alternatives
  • Authors: Treat comments as improvement opportunities, not criticism
  • Distinguish blocking (must fix) from non-blocking (suggestion)
  • Aim to complete reviews within 1 business day
  • Reviewer shares responsibility for quality after approving